feat: use ghcr image instead of docker#533
feat: use ghcr image instead of docker#533zMynxx wants to merge 4 commits intopy-cov-action:mainfrom
Conversation
|
Admin commands cheatsheet:
|
Coverage report
This PR does not seem to contain any modification to coverable code. |
|
Any updates on this? It looks like the CI failure is unrelated. |
Yeah the CI failure has nothing to do with it. |
| The Dockerfile used by this image can have both registeries as sources: | ||
| - ewjoachim/python-coverage-comment-action-base:v6 | ||
| - ghcr.io/py-cov-action/python-coverage-comment-action-base:v6 | ||
| Take your pick according to your needs. |
There was a problem hiding this comment.
It's unclear how users could change something there, I believe the choice we make is something everyone has to live with, no ?
Also, better not hardcode v6 in too many places !
ewjoachim
left a comment
ewjoachim
left a comment
There was a problem hiding this comment.
Excellent ! I left a single comment but I think we can merge all other files :)
|
I hope it's ok with you, but as I'll be needing this quite soon, I'm making my branch with your commits, I'll leave authorship and link to here. Thank you a ton for your work here ! |
|
Closing in favor of #540 but by all means, don't take it as a way to say your contribution wasn't appreciated ! It was, it's just GitHub's way of collaborating on forks is limited :) |
|
Now released, thanks a lot! https://github.com/py-cov-action/python-coverage-comment-action/releases/tag/v3.31 |
3 participants
Avoid a common issue
429 too many requestsdue to the super-low DockerHub unauthenticated pulls limit.Use GHCR instead.